Skip to content

Comments

Refactor/19/codereveiw chanki#22

Merged
cksrlcks merged 4 commits intomainfrom
refactor/19/codereveiw-chanki
Feb 4, 2025
Merged

Refactor/19/codereveiw chanki#22
cksrlcks merged 4 commits intomainfrom
refactor/19/codereveiw-chanki

Conversation

@cksrlcks
Copy link
Collaborator

@cksrlcks cksrlcks commented Feb 4, 2025

โ“์ด์Šˆ

โœ๏ธ Description

2์›”4์ผ์— ํŒ€๋ฉ˜ํ† ๋ง ์‹œ๊ฐ„์— ๋ฐ›์€ ์ฝ”๋“œ๋ฆฌ๋ทฐ ๊ฐœ์„ ์‚ฌํ•ญ์„ ์ž‘์—…ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • ์ปจํ…์ธ  ๋ฐ์ดํ„ฐ, ๋„ค๋น„๊ฒŒ์ด์…˜ ๋ฐ์ดํ„ฐ ํƒ€์ž… ์ถ”๊ฐ€
  • ๊ฐœ์ธ์ •๋ณด์ฒ˜๋ฆฌ๋ฐฉ์นจ ํŽ˜์ด์ง€ ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์ปดํฌ๋„ŒํŠธ ๊ฐœ์„  (์ด๋ฏธ tailwind์— ์„ค์ •๋œ typography๋ฅผ ๋…ธ์ถœ)

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

- ์ปจํ…์ธ  ๋ฐ์ดํ„ฐ ๋ถ„๋ฆฌ
- ์ปจํ…์ธ  ํƒ€์ž… ์ง€์ •
- ํƒ€์ดํฌ๊ทธ๋ž˜ํ”ผ ์ปดํฌ๋„ŒํŠธ ์ œ๊ฑฐ(์ด๋ฏธ tailwind์— ์„ค์ •๋œ typography๋ฅผ ๋…ธ์ถœ)
- ์ปจํ…์ธ  ํƒ€์ž… ์ง€์ •
- map key์— index์ œ๊ฑฐ
@cksrlcks cksrlcks added Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง labels Feb 4, 2025
@cksrlcks cksrlcks requested a review from ToKyun02 February 4, 2025 12:17
@cksrlcks cksrlcks self-assigned this Feb 4, 2025
@vercel
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 4, 2025 1:07pm

@ToKyun02
Copy link
Owner

ToKyun02 commented Feb 4, 2025

์˜ค๋Š˜ ๋ฉ˜ํ† ๋ง ๋•Œ ํ”ผ๋“œ๋ฐฑ ๋‚˜์˜จ ์˜๊ฒฌ ์ ์šฉํ•˜์‹ ๊ฑฐ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!
๊ณ ์ƒ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค.

ํ™•์‹คํžˆ ํ”ผ๋“œ๋ฐฑ ๋ฐ›์€ ์˜๊ฒฌ์„ ์ ์šฉํ•œ ์ฝ”๋“œ๋ฅผ ๋ณด๋‹ˆ ์กฐ๊ธˆ ๋” ์•ˆ์ •์ ์ด๋ผ๊ณ  ๋А๊ปด์ง€๋„ค์š”.

์ถ”๊ฐ€๋กœ, ํ˜น์‹œ ๋žœ๋”ฉํŽ˜์ด์ง€์—์„œ ์Šคํฌ๋กค ๋‚ด๋ฆด ๋•Œ ์นด๋“œ๋“ค์ด ํ—ค๋” ์˜์—ญ์„ ๊ฐ€๋ฆฌ๋Š”๋ฐ, ์˜๋„๋œ๊ฑด๊ฐ€์š”?
์•„๋ž˜๋Š” ์˜ˆ์‹œ์ž…๋‹ˆ๋‹ค.

์šฐ์„  ๋ณธ PR ๋‚ด์šฉ๊ณผ ๊ด€๊ณ„์—†๋Š” ์ด์•ผ๊ธฐ์ด๋‹ˆ ์Šน์ธํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!
image

@cksrlcks
Copy link
Collaborator Author

cksrlcks commented Feb 4, 2025

์•„ motion์ด ์ ์šฉ๋œ ์š”์†Œ๋“ค์ด z-index๊ฐ€ ๋” ๋†’์•„์ง€๋Š”๊ตฐ์šค
ํ—ค๋”์— z-index์ถ”๊ฐ€ํ•ด๋‘˜๊ป˜์šฅ!

@cksrlcks cksrlcks merged commit 5a9720e into main Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor : ๋ฉ˜ํ† ๋ง ์ฝ”๋“œ๋ฆฌ๋ทฐ ๊ฐœ์„ ์‚ฌํ•ญ ์ž‘์—… (๊น€์ฐฌ๊ธฐ)

2 participants